Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDFAB-1150] Detect failure & restore P4rt channel in PFCP Agent #599

Merged
merged 13 commits into from
Apr 1, 2022
Merged

[SDFAB-1150] Detect failure & restore P4rt channel in PFCP Agent #599

merged 13 commits into from
Apr 1, 2022

Conversation

osinstom
Copy link
Contributor

@osinstom osinstom commented Mar 30, 2022 •
edited
Loading

PFCP Agent is already able to detect UP4 failure and restore P4rt channel. This PR adds an integration test to verify that UP4 failure is properly detected and P4rt channel is restored.

Also, it introduces a configuration parameter to decide whether to clear datapath state on UP4 restart.

@osinstom osinstom changed the title Detect up4 restart [SDFAB-1150] Add integration test for detecting UP4 failure Mar 30, 2022
@osinstom osinstom changed the title [SDFAB-1150] Add integration test for detecting UP4 failure [SDFAB-1150] Detect failure & restore P4rt channel in PFCP Agent Mar 31, 2022
@osinstom osinstom marked this pull request as ready for review March 31, 2022 18:14
@osinstom
Copy link
Contributor Author

@pudelkoM @ccascone the integration test failed because we recently allowed to allocate counter ID = 0, but we still check in the assertions if counter ID doesn't equal 0. I'll fix it in a separate PR and will just re-run tests here.

@osinstom osinstom merged commit de35ad7 into master Apr 1, 2022
@osinstom osinstom deleted the detect-up4-restart branch April 1, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pudelkoM pudelkoM pudelkoM approved these changes

@ccascone ccascone Awaiting requested review from ccascone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osinstom @pudelkoM